I went for my first time. It was fun and I'll likely attend again since I'm close, but not much I wanted. Seemed like a lot of overpriced postwar stuff, some just straight junk. Lots of 736s in average condition asking $400 for example when I can get one in better condition on ebay for under $300 all day long after shipping and taxes.
I picked up a Marx yard light in great condition for $10. I almost got a Reading diesel AA set but the seller Hulked it out of the styrofoam and broke a piece off of the diecast truck and I passed.
Trainz had a deal the week before where they'd bring the items to York to save on shipping. I got a working 282 gantry crane for $73 after a $10 off coupon code. It's great!