Like any organization, you get out of it what you put into it. There is a lot of misinformation regarding the TCA, it's budget and it organization.
For me, TCA national is a ticket to be involved with my Division which has 10 meets a year for members, operates trains on a portable layout for the public, hosts an annual train show, has a spring picnic, 2 to 3 auctions per year where I can get very well priced trains, and a Christmas Dinner. The friends I have met through local involvement are friends for life and I have been exposed to a world of trains I never would have cared anything about had it not been for involvement. I have had the honor to serve in several positions at the national level and while no organization is perfect, there is no lack of enthusiasm to preserve the hobby in it's collections and publications.
Remember the York show is not a National TCA function, it is an Eastern Division meet. It is not totally true that anyone can get in as only the Orange and brown halls are open to the public. Those halls are dealer and manufacturer halls only. The remaining halls are still members only where you find the more collectible, and or unusual finds.
The museum is no longer the money pit it once was. There has been very good management of the museum and it's budget over the last 10 years and a lot of deferred maintenance has been completed.
I find it interesting that $50 a year seems too high for membership when a new boxcar from Lionel is $80.00 and people regularly spend thousands of dollars a year on their personal collections. My memberships to other organizations is in line with the price of TCA membership. PRRT&HS is $40. A local operating club I belong to is $100 per year. That is cheap compared to my professional society membership which is over $700 a year, or my professional licenses that are anywhere from $75 to $225 a year.
I would encourage you if you can to get more involved and you will see the value. Even just seeing old friends at York is worth the price alone. I'll be working in the Orange Hall for 3rd Rail in April. Hope too see forum members there!